[ENG-84] Toast not closing
#2657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for decent-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
DarksightKellar
approved these changes
Jan 9, 2025
mudrila
approved these changes
Jan 9, 2025
| @@ -37,9 +37,7 @@ export function SafeCreatePage() { | |||
| if (daoFound) { | |||
| navigate(DAO_ROUTES.dao.relative(addressPrefix, safeAddress)); | |||
| } else { | |||
| toast.loading(t('failedIndexSafe'), { | |||
| duration: Infinity, | |||
There was a problem hiding this comment.
Yeah, this thingy was intentional previously :)
But I know from user feedback that it's rather confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looks like this was set to
infinity, removed that.Closes ENG-84
Testing
As this particular toast is part of a failure workflow, might take a few tries to reproduce. I have this happen more often when creating Token DAOs, so I'd recommend that, if you are itching to test, otherwise, pretty straight forward fix.
Screenshots
No Screenshots